Skip to content

Conversation

@BillFarber
Copy link
Contributor

The previous descriptions were identical across multiple files. This makes debugging much easier.

Copilot AI review requested due to automatic review settings October 17, 2025 15:41
@BillFarber BillFarber requested a review from anu3990 October 17, 2025 15:41
@BillFarber BillFarber requested a review from stevebio as a code owner October 17, 2025 15:41
@github-actions
Copy link

Copyright Validation Results
Total: 6 | Passed: 6 | Failed: 0 | Skipped: 0 | at: 2025-10-17 15:42:14 UTC | commit: b704590

✅ Valid Files

  • test-basic/documents-data-movement-transformAll.js
  • test-complete/nodejs-dmsdk-queryToTransformAll.js
  • test-complete/nodejs-dmsdk-removeAllUris.js
  • test-complete/nodejs-dmsdk-transformAll.js
  • test-complete/nodejs-dmsdk-txtFiles-transformAll.js
  • test-complete/nodejs-dmsdk-xmlFiles-transformAll.js

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances test descriptions by appending unique file identifiers to previously identical test suite names, making it easier to identify which test file is running or failing during debugging.

Key Changes:

  • Updated describe() block descriptions across 6 test files to include file-specific identifiers in parentheses

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test-complete/nodejs-dmsdk-xmlFiles-transformAll.js Added "(nodejs-dmsdk-xmlFiles-transformAll)" to test description
test-complete/nodejs-dmsdk-txtFiles-transformAll.js Added "(nodejs-dmsdk-txtFiles-transformAll)" to test description
test-complete/nodejs-dmsdk-transformAll.js Added "(nodejs-dmsdk-transformAll)" to test description
test-complete/nodejs-dmsdk-removeAllUris.js Added "nodejs-dmsdk-removeAllUris" to test description
test-complete/nodejs-dmsdk-queryToTransformAll.js Added "- nodejs-dmsdk-queryToTransformAll" to test description
test-basic/documents-data-movement-transformAll.js Added "(documents-data-movement-transformAll)" to test description

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

let uris = [];

describe('Functional tests - data movement removeAllUris', function () {
describe('Functional tests - data movement - nodejs-dmsdk-removeAllUris', function () {
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent formatting compared to other test descriptions. While most files use parentheses to wrap the file identifier (e.g., '(nodejs-dmsdk-transformAll)'), this file uses hyphens. Consider using 'Functional tests - data movement (nodejs-dmsdk-removeAllUris)' for consistency.

Suggested change
describe('Functional tests - data movement - nodejs-dmsdk-removeAllUris', function () {
describe('Functional tests - data movement (nodejs-dmsdk-removeAllUris)', function () {

Copilot uses AI. Check for mistakes.
const query = q.where(ctsQb.cts.directoryQuery('/test/dataMovement/requests/transformAll/'));

describe('data movement transformAll', function () {
describe('data movement transformAll - nodejs-dmsdk-queryToTransformAll', function () {
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent formatting compared to other test descriptions. While most files use parentheses to wrap the file identifier (e.g., '(nodejs-dmsdk-transformAll)'), this file uses a hyphen separator. Consider using 'data movement transformAll (nodejs-dmsdk-queryToTransformAll)' for consistency.

Suggested change
describe('data movement transformAll - nodejs-dmsdk-queryToTransformAll', function () {
describe('data movement transformAll (nodejs-dmsdk-queryToTransformAll)', function () {

Copilot uses AI. Check for mistakes.
@BillFarber BillFarber merged commit 0f96e98 into marklogic:develop Oct 17, 2025
2 checks passed
@BillFarber BillFarber deleted the addMoreInfoToTestDescriptions branch October 17, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants